Skip to content

fix(pd-store): correct license in hugegraph-pd#2446

Merged
imbajin merged 3 commits intopd-storefrom
pd-license-header
Feb 20, 2024
Merged

fix(pd-store): correct license in hugegraph-pd#2446
imbajin merged 3 commits intopd-storefrom
pd-license-header

Conversation

@VGalaxies
Copy link
Contributor

@VGalaxies VGalaxies commented Feb 6, 2024 •
edited
Loading

subtask of #2265

follow up #2435 on pd-store branch

this PR removed some meaningless configuration files

hugegraph-pd/build-pre.sh
hugegraph-pd/build.sh
hugegraph-pd/ci.yml
hugegraph-pd/deploy-release.sh
hugegraph-pd/deploy-snapshot.sh
hugegraph-pd/local-release.sh
hugegraph-pd/settings.xml

@VGalaxies VGalaxies requested a review from imbajin February 6, 2024 13:34
@VGalaxies VGalaxies self-assigned this Feb 6, 2024
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. ci-cd Build or deploy labels Feb 6, 2024
@VGalaxies VGalaxies added the pd PD module label Feb 6, 2024
@codecov
Copy link

codecov bot commented Feb 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (pd-store@7b14857). Click here to learn what that means.

Additional details and impacted files 
@@             Coverage Diff             @@
##             pd-store    #2446   +/-   ##
===========================================
  Coverage            ?   55.26%           
  Complexity          ?     1904           
===========================================
  Files               ?      718           
  Lines               ?    58293           
  Branches            ?     7483           
===========================================
  Hits                ?    32218           
  Misses              ?    22895           
  Partials            ?     3180

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VGalaxies VGalaxies mentioned this pull request Feb 6, 2024
Closed
26 tasks
@VGalaxies
Copy link
Contributor Author

VGalaxies commented Feb 6, 2024 •
edited
Loading

@Pengzna could also help check it by following the guide from Project Migration/Package Name Change + IDEA Configuration Instructions (Complete Version)~

imbajin
imbajin approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked almost all files (exclude deleted files) , other enhancement could wait until the server done

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 7, 2024
@imbajin
Copy link
Member

imbajin commented Feb 20, 2024

checked almost all files (exclude deleted files) , other enhancement could wait until the server done

@msgui @returnToInnocence follow the #2435 (unify pd & store modules later)

@imbajin imbajin merged commit d61aaae into pd-store Feb 20, 2024
@imbajin imbajin deleted the pd-license-header branch February 20, 2024 10:28
@VGalaxies VGalaxies mentioned this pull request Mar 16, 2024
Closed
9 tasks
@Pengzna Pengzna mentioned this pull request Mar 16, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imbajin imbajin imbajin approved these changes

Assignees

@VGalaxies VGalaxies

Labels

ci-cd Build or deploy lgtm This PR has been approved by a maintainer pd PD module size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

HugeGraph PD-Store Tasks
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@VGalaxies @imbajin